Skip to content

Handle more cases with the new entry point pattern#33500

Merged
davidfowl merged 4 commits intomainfrom
davidfowl/waf-handle-edgecases
Jun 18, 2021
Merged

Handle more cases with the new entry point pattern#33500
davidfowl merged 4 commits intomainfrom
davidfowl/waf-handle-edgecases

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Jun 13, 2021

  • Handle an exception being thrown from main before start is called and make sure it propagates to the WebApplicationFactory.
  • Don't hang if the application doesn't call Start before it completes.

@davidfowl
Handle more cases with the new entry point pattern
ee415b3 
- Handle an exception being thrown from main before start is called and make sure it propagates to the WebApplicationFactory.
- Don't hang if the application doesn't call Start before it completes.
@davidfowl
Copy link
Member Author

davidfowl commented Jun 14, 2021

/azp run

I just fixed this dotnet/runtime#54133 and this hang might be related.

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 14, 2021

Command 'run

I' is not supported by Azure Pipelines.



Supported commands

  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@davidfowl
Copy link
Member Author

davidfowl commented Jun 14, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 14, 2021

Azure Pipelines successfully started running 2 pipeline(s).

captainsafia
captainsafia reviewed Jun 14, 2021
View reviewed changes
AspNetCore.sln
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNetCore.Components.WebView.Photino", "src\Components\WebView\Samples\PhotinoPlatform\src\Microsoft.AspNetCore.Components.WebView.Photino.csproj", "{B1AA24A4-5E02-4DC1-B57F-6EB03F91E4DD}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SimpleWebSiteWithWebApplicationBuilderException", "src\Mvc\test\WebSites\SimpleWebSiteWithWebApplicationBuilderException\SimpleWebSiteWithWebApplicationBuilderException.csproj", "{5C641396-7E92-4F5C-A5A1-B4CDF480539B}"
Copy link
Contributor

@captainsafia captainsafia Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to create a new test project for each of these scenarios or is there a way for us to have one test project with multiple apps for each scenario (app runs fine, app throws exception, etc)?

Copy link
Member Author

@davidfowl davidfowl Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have a single app that changed behavior based on arguments.

@davidfowl
Copy link
Member Author

davidfowl commented Jun 15, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 15, 2021

Azure Pipelines successfully started running 2 pipeline(s).

@davidfowl
Copy link
Member Author

davidfowl commented Jun 15, 2021

This is still hanging, I need to look at the dump

@davidfowl
Copy link
Member Author

davidfowl commented Jun 16, 2021

I just realized we're still on an older runtime build that doesn't have my latest fixes.

@dougbu it turns out this change still carries and older version of HostFactoryResolver. We're still pretty behind even though the PR was 11 hours ago, the content is 2 days old.

@davidfowl
Copy link
Member Author

davidfowl commented Jun 16, 2021

/backport to release/6.0-preview6

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2021

Started backporting to release/6.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/941882086

@github-actions github-actions bot mentioned this pull request Jun 16, 2021
Closed
@dougbu
Copy link
Contributor

dougbu commented Jun 16, 2021

I just realized we're still on an older runtime build that doesn't have my latest fixes.

This relates to dotnet/arcade#7532 but @epananth at least temporarily worked around that and got new dotnet/runtime versions into the '.NET 6' and '.NET 6 Preview 6' channels. You're waiting for #33560 in main and (for #33574) #33571 in release/6.0-preview6. Both are blocked by our need to react to dotnet/runtime#54147.

halter73
halter73 reviewed Jun 16, 2021
View reviewed changes
@davidfowl
Copy link
Member Author

davidfowl commented Jun 16, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 16, 2021

Azure Pipelines successfully started running 2 pipeline(s).

@davidfowl
Copy link
Member Author

davidfowl commented Jun 18, 2021

/backport to release/6.0-preview6

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2021

Started backporting to release/6.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/949078033

@davidfowl davidfowl merged commit 746b9f8 into main Jun 18, 2021
@davidfowl davidfowl deleted the davidfowl/waf-handle-edgecases branch June 18, 2021 07:37
@ghost ghost added this to the 6.0-preview7 milestone Jun 18, 2021
@davidfowl
Copy link
Member Author

davidfowl commented Jun 18, 2021

/backport to release/6.0-preview6

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2021

Started backporting to release/6.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/949087635

@github-actions github-actions bot mentioned this pull request Jun 18, 2021
Merged
jeffl8n added a commit to jeffl8n/aspnetcore that referenced this pull request Sep 18, 2021
@jeffl8n
Merge branch 'main' into issue-33587
a698a17 
* main:
  Handle more cases with the new entry point pattern (dotnet#33500)
  [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#33560)
  Refactor LongPolling in Java to avoid stackoverflow (dotnet#33564)
  Optimize QueryCollection (dotnet#32829)
  Switch to in-org action (dotnet#33610)
  Improve Codespaces + C# extension interaction (dotnet#33614)
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 left review comments

@javiercn javiercn javiercn approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

@pranavkm pranavkm Awaiting requested review from pranavkm

@Tratcher Tratcher Awaiting requested review from Tratcher

+1 more reviewer

@captainsafia captainsafia captainsafia left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

6.0-preview7

Development

Successfully merging this pull request may close these issues.

7 participants

@davidfowl @dougbu @halter73 @captainsafia @javiercn @Pilchie @amcasey